Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set createdAt manually in the CSV #641

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

qbarrand
Copy link
Contributor

operator-sdk now sets that field for us.
Make new environment variables for the signer and worker image names mandatory.

operator-sdk now sets that field for us.
Make new environment variables for the signer and worker image names
mandatory.
Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit 9eb9a35
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/6555d99659ff890009ef1f8a
😎 Deploy Preview https://deploy-preview-641--kubernetes-sigs-kmm.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2023
@yevgeny-shnaidman
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit da759a0 into kubernetes-sigs:main Nov 16, 2023
12 checks passed
@qbarrand qbarrand deleted the no-created-at branch November 16, 2023 09:39
qbarrand added a commit to qbarrand/kernel-module-management that referenced this pull request Nov 16, 2023
operator-sdk now sets that field for us.
Make new environment variables for the signer and worker image names
mandatory.
k8s-ci-robot pushed a commit that referenced this pull request Nov 16, 2023
operator-sdk now sets that field for us.
Make new environment variables for the signer and worker image names
mandatory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants